huaxingao commented on code in PR #14700:
URL: https://github.com/apache/iceberg/pull/14700#discussion_r2572407156
##########
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##########
@@ -36,6 +38,7 @@ public class RESTUtil {
private static final Joiner NAMESPACE_ESCAPED_JOINER =
Joiner.on(NAMESPACE_ESCAPED_SEPARATOR);
private static final Splitter NAMESPACE_ESCAPED_SPLITTER =
Splitter.on(NAMESPACE_ESCAPED_SEPARATOR);
+ private static final SecureRandom SECURE_RANDOM = new SecureRandom();
Review Comment:
new SecureRandom() is relatively expensive; one shared instance is
thread‑safe and sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
