shangxinli opened a new pull request, #370: URL: https://github.com/apache/iceberg-cpp/pull/370
Add ExpireSnapshots as a concrete implementation extending PendingUpdateTyped, following Gang's suggestion to avoid pure interfaces when there's only one implementation. Changes: - ExpireSnapshots is now a concrete class (not pure interface) - Builder methods (ExpireSnapshotId, ExpireOlderThan, etc.) are non-virtual for performance - Apply() and Commit() remain virtual (from PendingUpdateTyped) - Added placeholder implementations in expire_snapshots.cc - Updated tests to use concrete class directly - Added source file to CMakeLists.txt and meson.build This design provides: - Simpler one-class implementation (vs interface + impl) - No virtual function overhead for builder methods - Still polymorphic through PendingUpdate base (for Transaction) - Maintains fluent API and type safety Full implementation of Apply() and Commit() will be added in follow-up PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
