shangxinli commented on code in PR #368:
URL: https://github.com/apache/iceberg-cpp/pull/368#discussion_r2573087479
##########
src/iceberg/file_reader.cc:
##########
@@ -60,12 +60,12 @@ Result<std::unique_ptr<Reader>> ReaderFactoryRegistry::Open(
}
std::unique_ptr<ReaderProperties> ReaderProperties::default_properties() {
- return std::make_unique<ReaderProperties>();
+ return std::unique_ptr<ReaderProperties>(new ReaderProperties());
Review Comment:
For this specific case is actually safe because it is single expression,
immediately returned and no other allocations happening. But I thought we
generally prefer to use make_unique for it's safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
