RyanSkraba commented on code in PR #14713:
URL: https://github.com/apache/iceberg/pull/14713#discussion_r2573569672
##########
docs/docs/configuration.md:
##########
@@ -180,6 +180,7 @@ Required and optional properties to include while using
`google` authentication
| Property | Default
| Description |
|----------------------------|--------------------------------------------------|--------------------------------------------------|
| `gcp.auth.credentials-path`| Application Default Credentials (ADC)
| Path to a service account JSON key file. |
+| `gcp.auth.credentials-key` | Application Default Credentials (ADC)
| JSON string of a service account credential. |
Review Comment:
```suggestion
| `gcp.auth.credentials-json` | Application Default Credentials (ADC)
| JSON string of a service account credential. |
```
Just a suggestion: There's two other GCS connectors by Confluent and Aiven
that use `gcs.credentials.path` and `gcs.credentials.json` which are slightly
more descriptive at first glance. `key` by itself can be a bit confusing for
the intention.
It's too bad we didn't all standardize on the same names, but that ship has
sailed 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
