Tishj commented on PR #14297: URL: https://github.com/apache/iceberg/pull/14297#issuecomment-3593470151
This PR caught my eye, as I've implemented the equivalent in DuckDB: https://github.com/duckdb/duckdb/pull/19336 The PR description doesn't give much away, but I think the approach is similar to the proposed (interim) solution here: buffer the first rowgroup, infer the shredded schema from this, then finalize the file schema and start writing data. We've opted to create a `typed_value` even though the type isn't 100% consistent within the buffered data, as long as it's the most common. I think you're losing potential compression by not doing that. We've also added a copy option to force the shredded schema, for debugging purposes and for power users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
