geruh commented on code in PR #2789:
URL: https://github.com/apache/iceberg-python/pull/2789#discussion_r2574952948
##########
tests/io/test_pyarrow.py:
##########
@@ -3840,8 +3840,46 @@ def test_orc_schema_conversion_with_field_ids() -> None:
id_field_no_ids = arrow_schema_no_ids.field(0)
name_field_no_ids = arrow_schema_no_ids.field(1)
- assert not id_field_no_ids.metadata
- assert not name_field_no_ids.metadata
+ assert PYARROW_PARQUET_FIELD_ID_KEY not in id_field_no_ids.metadata
Review Comment:
There are some duplicate assertions here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
