gbrgr commented on code in PR #1824:
URL: https://github.com/apache/iceberg-rust/pull/1824#discussion_r2576999786
##########
crates/iceberg/src/arrow/record_batch_transformer.rs:
##########
@@ -163,32 +164,49 @@ impl RecordBatchTransformerBuilder {
Self {
snapshot_schema,
projected_iceberg_field_ids: projected_iceberg_field_ids.to_vec(),
- partition_spec: None,
- partition_data: None,
+ constant_fields: HashMap::new(),
}
}
+ /// Add a constant value for a specific field ID.
+ /// This is used for virtual/metadata fields like _file that have constant
values per batch.
+ ///
+ /// # Arguments
+ /// * `field_id` - The field ID to associate with the constant
+ /// * `value` - The constant value for this field
+ pub(crate) fn with_constant(mut self, field_id: i32, value:
PrimitiveLiteral) -> Result<Self> {
+ let arrow_type =
RecordBatchTransformer::primitive_literal_to_arrow_type(&value)?;
Review Comment:
Changed to use Datum along the way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
