shtripat opened a new pull request, #638:
URL: https://github.com/apache/iceberg-go/pull/638
Fixed RemoveSnapshotRef() to preserve snapshot log when removing MainBranch
reference during CREATE OR REPLACE TABLE operations. Previously cleared entire
snapshot history, causing testReplaceTableKeepsSnapshotLog RCK test to fail.
Now only resets current snapshot pointer while maintaining historical log
entries, matching Apache Iceberg Java spec behavior.
Below RCK test fails
```
RESTCompatibilityKitCatalogTests > testReplaceTableKeepsSnapshotLog() FAILED
java.lang.IndexOutOfBoundsException: index (1) must be less than size (1)
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1369)
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1351)
at
org.apache.iceberg.relocated.com.google.common.collect.SingletonImmutableList.get(SingletonImmutableList.java:46)
at
org.apache.iceberg.catalog.CatalogTests.testReplaceTableKeepsSnapshotLog(CatalogTests.java:2611)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
