pvary commented on code in PR #14729:
URL: https://github.com/apache/iceberg/pull/14729#discussion_r2580415727
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/CompareSchemasVisitor.java:
##########
@@ -88,7 +87,11 @@ public Result struct(Types.StructType struct, Integer
tableSchemaId, List<Result
}
for (Types.NestedField tableField :
tableSchemaType.asStructType().fields()) {
- if (tableField.isRequired() && struct.field(tableField.name()) == null) {
+ if (tableField.isRequired()
+ && (caseSensitive
+ ? struct.field(tableField.name())
+ : struct.caseInsensitiveField(tableField.name()))
+ == null) {
Review Comment:
nit: Maybe create a method like `equalFieldNames` or something better named
😄, and then we hide the ugly details, and don't increase complexity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
