pvary commented on code in PR #14728:
URL: https://github.com/apache/iceberg/pull/14728#discussion_r2581536573
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java:
##########
@@ -77,7 +77,11 @@ String branch(TableIdentifier identifier, String branch) {
}
ResolvedSchemaInfo schema(TableIdentifier identifier, Schema input) {
- return schema(identifier, input, true);
+ return schema(identifier, input, true, false);
Review Comment:
we usually add a comment to the boolean parameters if we can't avoid them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
