pvary commented on code in PR #14734:
URL: https://github.com/apache/iceberg/pull/14734#discussion_r2581685132
##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -2503,4 +2503,80 @@ public void testAddRequiredUnknown() {
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Cannot create required field with unknown type: unk");
}
+
+ @Test
+ public void testCaseInsensitiveAddTopLevelAndMove() {
+ Schema schema = new Schema(required(1, "id", Types.LongType.get()));
+
+ Schema expected =
+ new Schema(
+ optional(2, "data", Types.StringType.get()), required(1, "id",
Types.LongType.get()));
+
+ Schema actual =
+ new SchemaUpdate(schema, schema.highestFieldId())
+ .caseSensitive(false)
+ .addColumn("data", Types.StringType.get())
+ .moveFirst("DATA")
Review Comment:
nit: Let's try something like "dAtA"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
