jnagel12 commented on PR #629: URL: https://github.com/apache/iceberg-go/pull/629#issuecomment-3603144325
> Sure, I'm wondering if there's a good reason not to do it here in the view constructor, as in if there's any harm in it. Meaning in `NewViewVersion`? I was thinking about that. I guess if users in general should be building updates using the `MetadataBuilder`, it doesn't matter if we default the ID in that constructor to `1` since we reassign in the builder. How about I default it to `1` there and add a variadic version opt `WithViewVersionID` in case there are reasons to set manually? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
