kevinjqliu commented on code in PR #14724:
URL: https://github.com/apache/iceberg/pull/14724#discussion_r2582267189
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogServlet.java:
##########
@@ -133,6 +135,20 @@ protected void execute(ServletRequestContext context,
HttpServletResponse respon
}
}
+ private boolean canReturn204(Route route) {
Review Comment:
nit: should we gate this using both the route and method (GET/POST/HEAD)?
For example, in the `/v1/{prefix}/namespaces/{namespace}` route, only HEAD
supports 204
https://github.com/apache/iceberg/blob/29a144adca05344de2a8aab05e2b3385c4053c8f/open-api/rest-catalog-open-api.yaml#L383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
