smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2582532329
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -57,27 +65,45 @@ enum UpdateType {
private final String path;
private final Supplier<Map<String, String>> headers;
private final FileIO io;
+ private final KeyManagementClient kmsClient;
private final List<MetadataUpdate> createChanges;
private final TableMetadata replaceBase;
private final Set<Endpoint> endpoints;
private UpdateType updateType;
private TableMetadata current;
+ private EncryptionManager encryptionManager;
+ private EncryptingFileIO encryptingFileIO;
+ private String tableKeyId;
+ private int encryptionDekLength;
+ private List<EncryptedKey> encryptedKeysFromMetadata;
Review Comment:
Apologies for the delay here, there _is_ a case for this and this PR now
needs those changes - it's concurrent _replace_ transactions instead of append
transactions. I have the full patch
[here](https://github.com/smaheshwar-pltr/iceberg/compare/rest-encrypt-on-main-cherry-pick...smaheshwar-pltr:iceberg:rest-encrypt-replace-transaction?expand=1),
which I will rebase onto this PR once I've run some final tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
