openinx commented on code in PR #14443:
URL: https://github.com/apache/iceberg/pull/14443#discussion_r2583682491
##########
aliyun/src/main/java/org/apache/iceberg/aliyun/AliyunClientFactories.java:
##########
@@ -81,17 +88,82 @@ private static AliyunClientFactory loadClientFactory(
}
static class DefaultAliyunClientFactory implements AliyunClientFactory {
+ private static final Logger LOG =
LoggerFactory.getLogger(DefaultAliyunClientFactory.class);
Review Comment:
nit: We ususally define the `LOG` in the class file rather than the inner
class in apache iceberg. Maybe we can move it to the `AliyunClientFactories`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
