joyhaldar commented on code in PR #14593:
URL: https://github.com/apache/iceberg/pull/14593#discussion_r2544228923
##########
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java:
##########
@@ -327,6 +327,29 @@ public <T> Boolean eq(Bound<T> term, Literal<T> lit) {
public <T> Boolean notEq(Bound<T> term, Literal<T> lit) {
// because the bounds are not necessarily a min or max value, this
cannot be answered using
// them. notEq(col, X) with (X, Y) doesn't guarantee that X is a value
in col.
+ // However, when min == max and the file has no nulls or NaN values, we
can safely prune
+ // if that value equals the literal.
+ int id = term.ref().fieldId();
+ if (mayContainNull(id)) {
+ return ROWS_MIGHT_MATCH;
+ }
+ T lower = lowerBound(term);
+ T upper = upperBound(term);
+
+ if (lower == null || upper == null || NaNUtil.isNaN(lower) ||
NaNUtil.isNaN(upper)) {
+ return ROWS_MIGHT_MATCH;
+ }
+
+ if (nanCounts != null && nanCounts.containsKey(id) && nanCounts.get(id)
!= 0) {
+ return ROWS_MIGHT_MATCH;
+ }
+
+ if (lower.equals(upper)) {
+ int cmp = lit.comparator().compare(lower, lit.value());
Review Comment:
Thank you for the review Manu. I was trying to keep the logic inline to
match the existing code style in this file.
For example, the methods `lt()`, `gt()`, `ltEq()`, `gtEq()`, `eq()`, `in()`
all have similar variables declared, including this one,
`int cmp = lit.comparator().compare(lower, lit.value());`
I thought extracting it would be inconsistent with how other methods are
structured.
However, if you feel this is important for maintainability, I'm happy to
remove the local variable declaration. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
