c-thiel commented on code in PR #12584:
URL: https://github.com/apache/iceberg/pull/12584#discussion_r2585984915
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3964,6 +4144,292 @@ components:
metadata:
$ref: '#/components/schemas/TableMetadata'
+ EventsResponse:
+ type: object
+ required:
+ - highest-processed-timestamp-ms
+ - events
+ properties:
+ next-page-token:
+ $ref: "#/components/schemas/PageToken"
+ highest-processed-timestamp-ms:
Review Comment:
Only the `next-page-token` can and should be used for a query checkpoint and
it is only valid for the same filter combination.
We had some discussion about using a global sequence number instead, but
settled in a discussion that not all catalogs offer a global sequence number,
so we cannot rely on it for pagination. `highest-processed-timestamp-ms` is
only informational for the user, so that clients get an idea on what events
have been included in the current batch.
If we introduce the concept of a global sequence number elsewhere
(presumably optional?) we should introdcue this as a new field in the request &
response objects of the Events Endpoint as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
