dennishuo commented on code in PR #10877:
URL: https://github.com/apache/iceberg/pull/10877#discussion_r2586166075
##########
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##########
@@ -26,28 +26,29 @@
import org.apache.iceberg.relocated.com.google.common.base.Joiner;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.base.Splitter;
+import org.apache.iceberg.relocated.com.google.common.base.Strings;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+@SuppressWarnings("UnicodeEscape")
public class RESTUtil {
- private static final char NAMESPACE_SEPARATOR = '\u001f';
- private static final String NAMESPACE_ESCAPED_SEPARATOR = "%1F";
- private static final Joiner NAMESPACE_ESCAPED_JOINER =
Joiner.on(NAMESPACE_ESCAPED_SEPARATOR);
- private static final Splitter NAMESPACE_ESCAPED_SPLITTER =
- Splitter.on(NAMESPACE_ESCAPED_SEPARATOR);
+ private static final char NAMESPACE_SEPARATOR_AS_UNICODE = '\u001f';
+ static final String NAMESPACE_SEPARATOR_AS_UTF_8 = "%1F";
Review Comment:
I believe this is would be more accurately named
`NAMESPACE_SEPARATOR_URLENCODED_UTF_8`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
