nastra commented on code in PR #14740:
URL: https://github.com/apache/iceberg/pull/14740#discussion_r2587898964
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -152,6 +164,30 @@ public void createCatalog() throws Exception {
adapterForRESTServer =
Mockito.spy(
new RESTCatalogAdapter(backendCatalog) {
+ @Override
+ public <T extends RESTResponse> T handleRequest(
Review Comment:
instead of handling this globally for all tests and introducing
`idempHeaderExpectation` and `advertiseIdempInConfig` it's probably better to
use a custom `RESTCatalogAdapter` for the 2 new tests that you're adding. One
example where this is done is in `verifyNamespaceExistsFallbackToGETRequest`
and we could use the same approach in the new tests as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
