gaborkaszab commented on code in PR #13560: URL: https://github.com/apache/iceberg/pull/13560#discussion_r2588942306
########## core/src/main/java/org/apache/iceberg/metrics/CacheMetrics.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.metrics; + +import com.github.benmanes.caffeine.cache.stats.CacheStats; +import org.immutables.value.Value; + [email protected] +public abstract class CacheMetrics { + public abstract long hitCount(); + + public abstract long missCount(); + + public abstract long loadSuccessCount(); + + public abstract long loadFailureCount(); + + public abstract long totalLoadTime(); + + public abstract long evictionCount(); + + public abstract long evictionWeight(); Review Comment: Initially we are fine with the following list of metrics: hitCount, missCount, totalLoadTime and evictionCount. These are the ones that would add actual observability value to fine tune the manifest content cache IMO. Note, by narrowing the list we still don't solve the issue of different cache implementations have different stats, so maybe other implementations won't have totalLoadTime for instance. Would it still make sense to make the member non-primitive to have the ability of leaving them null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
