smaheshwar-pltr commented on code in PR #14752:
URL: https://github.com/apache/iceberg/pull/14752#discussion_r2589327929
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java:
##########
@@ -117,21 +117,73 @@ public void testRefresh() {
}
@TestTemplate
- public void testTransaction() {
- catalog.initialize(catalogName, catalogConfig);
+ public void testAppendTransaction() {
+ validationCatalog.initialize(catalogName, catalogConfig);
+ Table table = validationCatalog.loadTable(tableIdent);
- Table table = catalog.loadTable(tableIdent);
+ List<DataFile> dataFiles = currentDataFiles(table);
+ Transaction transaction = table.newTransaction();
+ AppendFiles append = transaction.newAppend();
+
+ // add an arbitrary datafile
+ append.appendFile(dataFiles.get(0));
+ append.commit();
+ transaction.commitTransaction();
+
+ assertThat(currentDataFiles(table)).hasSize(dataFiles.size() + 1);
+ }
+
+ @TestTemplate
+ public void testConcurrentAppendTransactions() {
+ validationCatalog.initialize(catalogName, catalogConfig);
+ Table table = validationCatalog.loadTable(tableIdent);
List<DataFile> dataFiles = currentDataFiles(table);
Transaction transaction = table.newTransaction();
AppendFiles append = transaction.newAppend();
// add an arbitrary datafile
append.appendFile(dataFiles.get(0));
+
+ // append to the table in the meantime. use a separate load to avoid
shared operations
+
validationCatalog.loadTable(tableIdent).newFastAppend().appendFile(dataFiles.get(0)).commit();
+
append.commit();
transaction.commitTransaction();
- assertThat(currentDataFiles(table).size()).isEqualTo(dataFiles.size() + 1);
+ assertThat(currentDataFiles(table)).hasSize(dataFiles.size() + 2);
+ }
+
+ // See CatalogTests#testConcurrentReplaceTransactions
+ @TestTemplate
+ public void testConcurrentReplaceTransactions() {
Review Comment:
This tests a replace retry - note that replace retries don't re-apply
updates to refreshed metadata, because they'll anyway replace the whole table.
#13225 didn't handle this case at one point, because it requires keys to be
maintained on refreshing _different_ metadata, so I think valuable to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
