amogh-jahagirdar commented on code in PR #14739:
URL: https://github.com/apache/iceberg/pull/14739#discussion_r2589622889
##########
core/src/main/java/org/apache/iceberg/ContentFileParser.java:
##########
@@ -345,4 +347,24 @@ private static PartitionData partitionFromJson(
return partitionData;
}
+
+ private static FileContent fileContentFromJson(String content) {
+ Preconditions.checkArgument(content != null, "Invalid file content: null");
+ switch (content) {
+ case "data":
+ return FileContent.DATA;
+ case "position-deletes":
+ return FileContent.POSITION_DELETES;
+ case "equality-deletes":
+ return FileContent.EQUALITY_DELETES;
Review Comment:
Yeah +1 to what @stevenzwu said. A convention has been established in the
spec for lower-case kebab, so I think we should handle that in the
implementation and be compatible with the older version as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
