pvary commented on code in PR #14746:
URL: https://github.com/apache/iceberg/pull/14746#discussion_r2591816073
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkOrcReadMetadataColumns.java:
##########
@@ -128,13 +135,43 @@ public void writeFile() throws IOException {
@TestTemplate
public void testReadRowNumbers() throws IOException {
- readAndValidate(null, null, null, EXPECTED_ROWS);
+ readAndValidate(null, null, null, EXPECTED_ROWS, NO_DELETES_FILTER);
+ }
+
+ @TestTemplate
+ public void testReadRowNumbersWithDelete() throws IOException {
+ assumeThat(vectorized).isTrue();
+
+ List<InternalRow> expectedRowsAfterDelete = Lists.newArrayList();
+ EXPECTED_ROWS.forEach(row -> expectedRowsAfterDelete.add(row.copy()));
+ // remove row at position 98, 99, 100, 101, 102, this crosses two row
groups [0, 100) and [100,
+ // 200)
+ for (int i = 98; i <= 102; i++) {
+ expectedRowsAfterDelete.get(i).update(3, true);
+ }
+
+ ORC.ReadBuilder builder =
ORC.read(Files.localInput(testFile)).project(PROJECTION_SCHEMA);
Review Comment:
Good catch!
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
