HuaHuaY commented on code in PR #373:
URL: https://github.com/apache/iceberg-cpp/pull/373#discussion_r2593454208
##########
src/iceberg/expression/aggregate.cc:
##########
@@ -115,13 +188,73 @@ class MinAggregator : public BoundAggregate::Aggregator {
return {};
}
- Literal GetResult() const override { return current_; }
+ Status Update(const DataFile& file) override {
+ if (!valid_) {
+ return {};
+ }
+ if (!aggregate_.HasValue(file)) {
+ valid_ = false;
+ return {};
+ }
+
+ ICEBERG_ASSIGN_OR_RAISE(auto value, aggregate_.Evaluate(file));
+ if (value.IsNull()) {
+ return {};
+ }
+ if (current_.IsNull()) {
+ current_ = std::move(value);
+ return {};
+ }
+
+ if (auto ordering = value <=> current_;
+ ordering == std::partial_ordering::unordered) {
+ return InvalidArgument("Cannot compare literal {} with current value {}",
+ value.ToString(), current_.ToString());
+ } else if (ordering == std::partial_ordering::less) {
+ current_ = std::move(value);
+ }
+ return {};
+ }
+
+ Literal GetResult() const override {
+ if (!valid_) {
+ return Literal::Null(GetPrimitiveType(*aggregate_.term()));
+ }
+ return current_;
+ }
+
+ bool IsValid() const override { return valid_; }
private:
const MinAggregate& aggregate_;
Literal current_;
+ bool valid_ = true;
};
+bool HasMapKey(const std::map<int32_t, int64_t>& map, int32_t key) {
Review Comment:
Is it meaningful to wrap `contains`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
