sfc-gh-ibelianski commented on code in PR #11041:
URL: https://github.com/apache/iceberg/pull/11041#discussion_r2593960362
##########
format/view-spec.md:
##########
@@ -63,11 +79,13 @@ The view version metadata file has the following fields:
| _required_ | `versions` | A list of known [versions](#versions)
of the view [1] |
| _required_ | `version-log` | A list of [version log](#version-log)
entries with the timestamp and `version-id` for every change to
`current-version-id` |
| _optional_ | `properties` | A string to string map of view
properties [2] |
+| _optional_ | `max-staleness-ms` | The maximum time interval in
milliseconds during which changed source table snapshots are considered fresh
enough to skip refreshing [3] |
Notes:
1. The number of versions to retain is controlled by the view property:
`version.history.num-entries`.
2. Properties are used for metadata such as `comment` and for settings that
affect view maintenance. This is not intended to be used for arbitrary metadata.
+3. The `max-staleness-ms` field only applies to materialized views and must be
set to `null` for common views. When `max-staleness-ms` is not `null`, the
query engine may return data directly from the `storage-table` without
refreshing if all source table snapshots that differ from those used in the
last refresh have timestamps within `max-staleness-ms` of the current time.
When `max-staleness-ms` is `null` for a materialized view, the data in the
`storage-table` is always considered fresh.
Review Comment:
this staleness definition is different from the one in the line 54 (in the
current form it seem to require to NOT implement optimization that is
mandated above in the line 54)
proposal:
The `max-staleness-ms`: defines staleness window for determining freshness
state see above section ### Materialized Views
PS
the same problem on line 82 (contradictory definition as opposed to
reference)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
