parthchandra commented on PR #13786: URL: https://github.com/apache/iceberg/pull/13786#issuecomment-3618633972
> @parthchandra Can we target Spark 4.0 first to make review and revise easier? Meanwhile, can you add more tests for the changes? @manuzhang appreciate your feedback and time spent on this PR. We started with just one Spark version in https://github.com/apache/iceberg/pull/13378 but that got no attention! One reason for keeping 3.4 is because we need to get one release of Iceberg out with Spark 3.4 support because Comet still supports Spark 3.4. The proposal to remove 3.4 has already been approved so we are racing against the clock here. If it helps, the Spark 3.4 and Spark 3.5 implementations are (nearly) identical to Spark 4.0. If the review focuses only on Spark 4.0, I can make sure the same changes are made for the other Spark version branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
