rdblue commented on a change in pull request #1743:
URL: https://github.com/apache/iceberg/pull/1743#discussion_r520065372
##########
File path:
spark3-extensions/src/main/scala/org/apache/iceberg/spark/extensions/IcebergSparkSessionExtensions.scala
##########
@@ -20,13 +20,15 @@
package org.apache.iceberg.spark.extensions
import org.apache.spark.sql.SparkSessionExtensions
+import org.apache.spark.sql.catalyst.analysis.ResolveProcedures
import
org.apache.spark.sql.catalyst.parser.extensions.IcebergSparkSqlExtensionsParser
import
org.apache.spark.sql.execution.datasources.v2.ExtendedDataSourceV2Strategy
class IcebergSparkSessionExtensions extends (SparkSessionExtensions => Unit) {
override def apply(extensions: SparkSessionExtensions): Unit = {
extensions.injectParser { case (_, parser) => new
IcebergSparkSqlExtensionsParser(parser) }
+ extensions.injectResolutionRule { _ => ResolveProcedures }
Review comment:
The ignored argument is a `SparkSession`, which I think should be passed
into `ResolveProcedures` so that it doesn't need to reference
`SparkSession.active`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
