aheev commented on PR #12584: URL: https://github.com/apache/iceberg/pull/12584#issuecomment-3620652960
> Summary of changes since early December 2025. Changes are motivated from discussions in this threads or learnings from the Rust request & response object implementations in [apache/iceberg-rust#1907](https://github.com/apache/iceberg-rust/pull/1907): > > * Allow JSON Values for custom filter (change `additionalProperties: type: String` to `additionalProperties: true` in [7f17a42](https://github.com/apache/iceberg/commit/7f17a42b4d274f495f6bb05c01f75e53145d8870) > * Make Actor an Object instead of a string in [3eeb95e](https://github.com/apache/iceberg/commit/3eeb95e7d0fdc4bc59cdb03804a98eac29d5b562). In most real-world szenarios an Actor will have more than one field, and even if not, the Catalog can simply return `{"id": "..."}`, which IMO would still be clearer and more extendable than a plain string. > * Add missing `updates` field to `CreateViewOperation` > * Rename `EventsResponse` to `QueryEventsResponse` > * Rename `CatalogObject` to `CatalogObjectIdentifier` > * Rename `event-count` in `Event` to `request-event-count` to be inline with `request-id` and hint a bit more that these are the events in a request and not the total events in the response > * Rename `page-token` to `continuation-token` and make it required. [For reasoning see Discussion](https://github.com/apache/iceberg/pull/12584#discussion_r2594784911) in [178ed3e](https://github.com/apache/iceberg/commit/178ed3ed9e0722cba2ca3eee173add06c89e5df1) > * Add missing `type: string` to `OperationType - anyof - enum` field in [c73e200](https://github.com/apache/iceberg/commit/c73e200627448df719b4f8c95581e082146962c4) > * Fix duplicate `namespace` field in `CreateNamespaceOperation` (via allOf and explicit) in [2f9b4db](https://github.com/apache/iceberg/commit/2f9b4db2e79f0f475c02b00700d336076428a070) > > Ping @stevenzwu @aheev Thanks a bunch :raised_hands: I was waiting for this. I will go ahead and apply in the other PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
