lgingerich commented on PR #1906: URL: https://github.com/apache/iceberg-rust/pull/1906#issuecomment-3622648484
Note: I'm a new reviewer/contributor in this repo, but trying to help out as PR reviews seems to be a heavily requested area of needed help. I've reviewed these changes and looked for potential missed needed updates. All looks good to me! Agreed that the failing test looks unrelated. I ran `cargo test -p iceberg-catalog-glue --test glue_catalog_test` locally on your branch and it passed successfully. Including a pic and link for the Iceberg spec for any other reviewers: Image from the [Iceberg spec](https://iceberg.apache.org/spec/#manifest-entry-fields) <img width="1656" height="370" alt="image" src="https://github.com/user-attachments/assets/6ba97f8a-1cbd-4a7c-81a9-43f5a02d27ff"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
