rdblue commented on a change in pull request #1742:
URL: https://github.com/apache/iceberg/pull/1742#discussion_r520199251
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerBaseTest.java
##########
@@ -176,6 +177,40 @@ public void testScanEmptyTable() throws IOException {
Assert.assertEquals(0, rows.size());
}
+ @Test
+ public void testDecimalTableWithPredicateLiterals() throws IOException {
+ shell.setHiveSessionValue("hive.vectorized.execution.enabled", "false");
+ Schema schema = new Schema(required(1, "decimal_field",
Types.DecimalType.of(7, 2)));
+ List<Record> records = TestHelper.RecordsBuilder.newInstance(schema)
+ .add(BigDecimal.valueOf(8500, 2)) // 85.00
+ .add(BigDecimal.valueOf(100.56))
+ .add(BigDecimal.valueOf(100.57))
Review comment:
I think test values should be created using strings so we know that we
know the exact BigDecimal values. Converting from float seems unreliable. The
one that uses an integer and a specific scale seems fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
