devendra-nr commented on code in PR #14618:
URL: https://github.com/apache/iceberg/pull/14618#discussion_r2601205707
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -79,6 +80,10 @@ public class IcebergSinkConfig extends AbstractConfig {
"iceberg.tables.schema-force-optional";
private static final String TABLES_SCHEMA_CASE_INSENSITIVE_PROP =
"iceberg.tables.schema-case-insensitive";
+ private static final String ERROR_TOLERANCE = "errors.tolerance";
Review Comment:
I defined these as per Kafka Connect specifications. Since these config
behaviours are defined by Kafka Connect framework already, I reused them.
Sharing the official doc links for the config names:
-
[errors.tolerance](https://kafka.apache.org/documentation/#sourceconnectorconfigs_errors.tolerance)
-
[errors.log.include.messages](https://kafka.apache.org/documentation/#sourceconnectorconfigs_errors.log.include.messages)
-
[errors.deadletterqueue.topic.name](https://kafka.apache.org/documentation/#sinkconnectorconfigs_errors.deadletterqueue.topic.name)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
