kevinjqliu commented on code in PR #14798:
URL: https://github.com/apache/iceberg/pull/14798#discussion_r2605031694
##########
baseline.gradle:
##########
@@ -182,7 +186,6 @@ subprojects {
}
pluginManager.withPlugin('scala') {
- String scalaVersion = System.getProperty("scalaVersion") != null ?
System.getProperty("scalaVersion") : System.getProperty("defaultScalaVersion")
Review Comment:
reviewer note, this is removed and now uses `scalaVersion` variable on L55
##########
baseline.gradle:
##########
@@ -63,18 +64,21 @@ subprojects {
licenseHeaderFile
"$rootDir/.baseline/copyright/copyright-header-java.txt"
}
- // Configure different scalafmt rules for specific Scala version
- if (project.name.startsWith("iceberg-spark") &&
project.name.endsWith("2.13")) {
- scala {
- target 'src/**/*.scala'
-
scalafmt("3.9.7").configFile("$rootDir/.baseline/scala/.scala213fmt.conf")
- licenseHeaderFile
"$rootDir/.baseline/copyright/copyright-header-java.txt", "package"
+ String scalafmtConfigFile = null
+ if (project.name.startsWith("iceberg-spark")) {
Review Comment:
```suggestion
if (project.name.startsWith("iceberg-spark")) {
String scalafmtConfigFile = null
```
##########
baseline.gradle:
##########
@@ -52,6 +52,7 @@ subprojects {
apply plugin: 'com.palantir.baseline-exact-dependencies'
apply plugin: 'com.diffplug.spotless'
+ String scalaVersion = System.getProperty("scalaVersion") != null ?
System.getProperty("scalaVersion") : System.getProperty("defaultScalaVersion")
Review Comment:
lets keep the original for consistency with other parts of the codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
