gaborkaszab commented on code in PR #14709:
URL: https://github.com/apache/iceberg/pull/14709#discussion_r2605941782
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -974,7 +974,12 @@ public List<ManifestFile> apply(TableMetadata base,
Snapshot snapshot) {
@Override
public Object updateEvent() {
long snapshotId = snapshotId();
- Snapshot justSaved = ops().refresh().snapshot(snapshotId);
+
+ Snapshot justSaved = ops().current().snapshot(snapshotId);
Review Comment:
That is the other approach I was considering. I didn't want
(Merging)SnapshotProducer to know about what is the underlying TableOps
implementation and I preferred this more general approach. Basically, instead
of asking "is this REST ops?" I ask "do we have this snapshot" that seemed more
robust and general.
WDYT @flyrain ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
