liurenjie1024 commented on code in PR #1915:
URL: https://github.com/apache/iceberg-rust/pull/1915#discussion_r2605965545
##########
crates/iceberg/src/arrow/caching_delete_file_loader.rs:
##########
@@ -374,10 +374,27 @@ impl CachingDeleteFileLoader {
row_predicate = row_predicate.and(cell_predicate)
}
}
- result_predicate = result_predicate.and(row_predicate.not());
+ row_predicates.push(row_predicate.not().rewrite_not());
}
}
- Ok(result_predicate.rewrite_not())
+
+ while row_predicates.len() > 1 {
Review Comment:
Please add a comment to explain why we need to do this optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
