zhjwpku commented on code in PR #402: URL: https://github.com/apache/iceberg-cpp/pull/402#discussion_r2606356494
########## src/iceberg/expression/residual_evaluator.cc: ########## @@ -0,0 +1,565 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "iceberg/expression/residual_evaluator.h" + +#include "iceberg/expression/binder.h" +#include "iceberg/expression/expression.h" +#include "iceberg/expression/expression_visitor.h" +#include "iceberg/expression/expressions.h" +#include "iceberg/expression/predicate.h" +#include "iceberg/partition_spec.h" +#include "iceberg/row/struct_like.h" +#include "iceberg/schema.h" +#include "iceberg/schema_internal.h" +#include "iceberg/transform.h" +#include "iceberg/util/checked_cast.h" +#include "iceberg/util/macros.h" + +namespace iceberg { + +class ResidualVisitor : public BoundVisitor<std::shared_ptr<Expression>> { + public: + ResidualVisitor(const std::shared_ptr<PartitionSpec>& spec, + const std::shared_ptr<Schema>& schema, const StructLike& partition_data, + bool case_sensitive) + : spec_(spec), + schema_(schema), + partition_data_(partition_data), + case_sensitive_(case_sensitive) { + ICEBERG_ASSIGN_OR_THROW(auto partition_type_, spec_->PartitionType(*schema)); + partition_schema_ = FromStructType(std::move(*partition_type_), std::nullopt); + } + + Result<std::shared_ptr<Expression>> AlwaysTrue() override { + return Expressions::AlwaysTrue(); + } + + Result<std::shared_ptr<Expression>> AlwaysFalse() override { + return Expressions::AlwaysFalse(); + } + + Result<std::shared_ptr<Expression>> Not( + const std::shared_ptr<Expression>& child_result) override { + return Expressions::Not(child_result); + } + + Result<std::shared_ptr<Expression>> And( + const std::shared_ptr<Expression>& left_result, + const std::shared_ptr<Expression>& right_result) override { + return Expressions::And(left_result, right_result); + } + + Result<std::shared_ptr<Expression>> Or( + const std::shared_ptr<Expression>& left_result, + const std::shared_ptr<Expression>& right_result) override { + return Expressions::Or(left_result, right_result); + } + + Result<std::shared_ptr<Expression>> IsNull( + const std::shared_ptr<Bound>& expr) override { + return IsNullImpl(expr); + } + + Result<std::shared_ptr<Expression>> NotNull( + const std::shared_ptr<Bound>& expr) override { + return NotNullImpl(expr); + } + + Result<std::shared_ptr<Expression>> IsNaN(const std::shared_ptr<Bound>& expr) override { + return IsNaNImpl(expr); + } + + Result<std::shared_ptr<Expression>> NotNaN( + const std::shared_ptr<Bound>& expr) override { + return NotNaNImpl(expr); + } + + Result<std::shared_ptr<Expression>> Lt(const std::shared_ptr<Bound>& expr, + const Literal& lit) override { + return LtImpl(expr, lit); + } + + Result<std::shared_ptr<Expression>> LtEq(const std::shared_ptr<Bound>& expr, + const Literal& lit) override { + return LtEqImpl(expr, lit); + } + + Result<std::shared_ptr<Expression>> Gt(const std::shared_ptr<Bound>& expr, + const Literal& lit) override { + return GtImpl(expr, lit); + } + + Result<std::shared_ptr<Expression>> GtEq(const std::shared_ptr<Bound>& expr, + const Literal& lit) override { + return GtEqImpl(expr, lit); + } + + Result<std::shared_ptr<Expression>> Eq(const std::shared_ptr<Bound>& expr, + const Literal& lit) override { + return EqImpl(expr, lit); + } + + Result<std::shared_ptr<Expression>> NotEq(const std::shared_ptr<Bound>& expr, + const Literal& lit) override { + return NotEqImpl(expr, lit); + } + + Result<std::shared_ptr<Expression>> StartsWith(const std::shared_ptr<Bound>& expr, + const Literal& lit) override { + return StartsWithImpl(expr, lit); + } + + Result<std::shared_ptr<Expression>> NotStartsWith(const std::shared_ptr<Bound>& expr, + const Literal& lit) override { + return NotStartsWithImpl(expr, lit); + } + + Result<std::shared_ptr<Expression>> In( + const std::shared_ptr<Bound>& expr, + const BoundSetPredicate::LiteralSet& literal_set) override { + return InImpl(expr, literal_set); + } + + Result<std::shared_ptr<Expression>> NotIn( + const std::shared_ptr<Bound>& expr, + const BoundSetPredicate::LiteralSet& literal_set) override { + return NotInImpl(expr, literal_set); + } + + Result<std::shared_ptr<Expression>> Predicate( + const std::shared_ptr<BoundPredicate>& pred) override; + + Result<std::shared_ptr<Expression>> Predicate( + const std::shared_ptr<UnboundPredicate>& pred) override { + ICEBERG_ASSIGN_OR_RAISE(auto bound_predicate, pred->Bind(*schema_, case_sensitive_)); + if (bound_predicate->is_bound_predicate()) { + ICEBERG_ASSIGN_OR_RAISE( + auto residual, + Predicate(std::dynamic_pointer_cast<BoundPredicate>(bound_predicate))); + if (residual->is_bound_predicate()) { + // replace inclusive original unbound predicate + return pred; + } + return residual; + } + // if binding didn't result in a Predicate, return the expression + return bound_predicate; + } + + private: + // Helper methods for bound predicates + Result<std::shared_ptr<Expression>> EvaluateBoundPredicate( + const std::shared_ptr<BoundPredicate>& pred); + + Result<std::shared_ptr<Expression>> IsNullImpl(const std::shared_ptr<Bound>& expr); + Result<std::shared_ptr<Expression>> NotNullImpl(const std::shared_ptr<Bound>& expr); + Result<std::shared_ptr<Expression>> IsNaNImpl(const std::shared_ptr<Bound>& expr); + Result<std::shared_ptr<Expression>> NotNaNImpl(const std::shared_ptr<Bound>& expr); + Result<std::shared_ptr<Expression>> LtImpl(const std::shared_ptr<Bound>& expr, + const Literal& lit); + Result<std::shared_ptr<Expression>> LtEqImpl(const std::shared_ptr<Bound>& expr, + const Literal& lit); + Result<std::shared_ptr<Expression>> GtImpl(const std::shared_ptr<Bound>& expr, + const Literal& lit); + Result<std::shared_ptr<Expression>> GtEqImpl(const std::shared_ptr<Bound>& expr, + const Literal& lit); + Result<std::shared_ptr<Expression>> EqImpl(const std::shared_ptr<Bound>& expr, + const Literal& lit); + Result<std::shared_ptr<Expression>> NotEqImpl(const std::shared_ptr<Bound>& expr, + const Literal& lit); + Result<std::shared_ptr<Expression>> InImpl( + const std::shared_ptr<Bound>& expr, + const BoundSetPredicate::LiteralSet& literal_set); + Result<std::shared_ptr<Expression>> NotInImpl( + const std::shared_ptr<Bound>& expr, + const BoundSetPredicate::LiteralSet& literal_set); + Result<std::shared_ptr<Expression>> StartsWithImpl(const std::shared_ptr<Bound>& expr, + const Literal& lit); + Result<std::shared_ptr<Expression>> NotStartsWithImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit); + + std::shared_ptr<PartitionSpec> spec_; + std::shared_ptr<Schema> schema_; + std::shared_ptr<Schema> partition_schema_; + const StructLike& partition_data_; + bool case_sensitive_; +}; + +Result<std::shared_ptr<Expression>> ResidualVisitor::IsNullImpl( + const std::shared_ptr<Bound>& expr) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value.IsNull()) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::NotNullImpl( + const std::shared_ptr<Bound>& expr) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value.IsNull()) { + return Expressions::AlwaysFalse(); + } + return Expressions::AlwaysTrue(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::IsNaNImpl( + const std::shared_ptr<Bound>& expr) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value.IsNaN()) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::NotNaNImpl( + const std::shared_ptr<Bound>& expr) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value.IsNaN()) { + return Expressions::AlwaysFalse(); + } + return Expressions::AlwaysTrue(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::LtImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value < lit) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::LtEqImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value <= lit) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::GtImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value > lit) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::GtEqImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value >= lit) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::EqImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value == lit) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::NotEqImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (value != lit) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::InImpl( + const std::shared_ptr<Bound>& expr, + const BoundSetPredicate::LiteralSet& literal_set) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (literal_set.contains(value)) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::NotInImpl( + const std::shared_ptr<Bound>& expr, + const BoundSetPredicate::LiteralSet& literal_set) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + if (literal_set.contains(value)) { + return Expressions::AlwaysFalse(); + } + return Expressions::AlwaysTrue(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::StartsWithImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + + // Both value and literal should be strings + if (!std::holds_alternative<std::string>(value.value()) || + !std::holds_alternative<std::string>(lit.value())) { + return Expressions::AlwaysFalse(); + } + + const auto& str_value = std::get<std::string>(value.value()); + const auto& str_prefix = std::get<std::string>(lit.value()); + if (str_value.starts_with(str_prefix)) { + return Expressions::AlwaysTrue(); + } + return Expressions::AlwaysFalse(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::NotStartsWithImpl( + const std::shared_ptr<Bound>& expr, const Literal& lit) { + ICEBERG_ASSIGN_OR_RAISE(auto value, expr->Evaluate(partition_data_)); + + // Both value and literal should be strings + if (!std::holds_alternative<std::string>(value.value()) || + !std::holds_alternative<std::string>(lit.value())) { + return Expressions::AlwaysTrue(); + } + + const auto& str_value = std::get<std::string>(value.value()); + const auto& str_prefix = std::get<std::string>(lit.value()); + if (str_value.starts_with(str_prefix)) { + return Expressions::AlwaysFalse(); + } + return Expressions::AlwaysTrue(); +} + +Result<std::shared_ptr<Expression>> ResidualVisitor::EvaluateBoundPredicate( Review Comment: Let me try using the BoundVisitor::Predicate directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
