nastra commented on code in PR #14776:
URL: https://github.com/apache/iceberg/pull/14776#discussion_r2606761060
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTScanPlanning.java:
##########
@@ -424,7 +439,11 @@ public void
metadataTablesWithRemotePlanning(MetadataTableType type) throws IOEx
// tasks, this test just verifies that metadata tables can be scanned with
RESTTable.
Table metadataTableInstance =
MetadataTableUtils.createMetadataTableInstance(table, type);
assertThat(metadataTableInstance).isNotNull();
- assertThat(metadataTableInstance.newScan().planFiles()).isNotEmpty();
+ if (!type.equals(MetadataTableType.POSITION_DELETES)) {
Review Comment:
nit: you might want to switch the condition to have `if type is
position_deletes then do X else do Y`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
