findepi commented on code in PR #14392:
URL: https://github.com/apache/iceberg/pull/14392#discussion_r2607173661
##########
core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java:
##########
@@ -129,7 +129,7 @@ public static Schema pruneColumns(Schema schema,
Set<Integer> selectedIds) {
}
/**
- * @deprecated will be removed in 2.0.0; use applyNameMapping and
pruneColumns(Schema, Set)
+ * @deprecated will be removed in 1.12.0; use applyNameMapping and
pruneColumns(Schema, Set)
Review Comment:
> however in the core/ module we could be less strict and provide guarantees
for one minor release
is this written down somewhere so that we can reference the rules of the
games when deprecating?
community syncs meeting notes are not normative, we should capture important
conclusions somewhere
btw, i don't think this 1 minor release guarantee means much in practice.
maven world reality is that minor version update may just happen when combining
various artifacts for the final delivery, so removing an API may obviously lead
to MethodDefNotFoundError. This may be a fair trade off, i just hope it's a
conscious one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
