lgingerich opened a new issue, #1924:
URL: https://github.com/apache/iceberg-rust/issues/1924

   ### Is your feature request related to a problem or challenge?
   
   Multiple instances of match expressions over the `PrimitiveType` use a 
wildcard even though the enum is exhaustive. If more types were to be added to 
`PrimitiveType`, this wildcard would silently swallow usage of those types. 
Some of these instances currently throw `ErrorKind::FeatureUnsupported`. They 
also have hardcoded `Timestamptz` since it's the only unsupported type. 
Examples can be seen 
[here](https://github.com/apache/iceberg-rust/blob/2ed0a6f509a5c6e7bdb143a74fa79c59a9df1bf2/crates/catalog/glue/src/schema.rs#L179-L180)
 and 
[here](https://github.com/apache/iceberg-rust/blob/2ed0a6f509a5c6e7bdb143a74fa79c59a9df1bf2/crates/catalog/hms/src/schema.rs#L136-L137).
   
   This issue is to document and fix instances of wildcard usage in exhaustive 
enums.
   
   ### Describe the solution you'd like
   
   - Remove wildcard in exhaustive match expressions
   - Add necessary attributes for exhaustive enums in match expressions
   
   ### Willingness to contribute
   
   I can contribute to this feature independently


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to