liurenjie1024 commented on code in PR #1922:
URL: https://github.com/apache/iceberg-rust/pull/1922#discussion_r2610054042
##########
crates/iceberg/src/arrow/record_batch_transformer.rs:
##########
@@ -83,14 +83,10 @@ fn constants_map(
// Handle both None (null) and Some(Literal::Primitive) cases
match &partition_data[pos] {
None => {
- // TODO
(https://github.com/apache/iceberg-rust/issues/1914): Add support for null
datum values.
- return Err(Error::new(
- ErrorKind::Unexpected,
- format!(
- "Partition field {} has null value for identity
transform",
- field.source_id
- ),
- ));
+ // Skip null partition values - they will be resolved as
null per Iceberg spec rule #4.
Review Comment:
I think there is a corner case where this approach will fail, as spec says
identity partition should override values from underlying files, with this fix
we will still return values from underlying files rather than null identity
partition value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
