ebyhr commented on code in PR #14820:
URL: https://github.com/apache/iceberg/pull/14820#discussion_r2612640722
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -2444,6 +2480,14 @@ private long totalSizeInBytes(Iterable<DataFile>
dataFiles) {
return
Lists.newArrayList(dataFiles).stream().mapToLong(DataFile::fileSizeInBytes).sum();
}
+ private long totalDeleteFileSizeInBytes(Iterable<DeleteFile> deleteFiles,
FileContent content) {
Review Comment:
nit: This method can be static.
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1291,6 +1298,11 @@ public void testUnpartitionedPartitionsTable() {
"equality_delete_file_count",
Types.IntegerType.get(),
"Count of equality delete files"),
+ required(
+ 13,
+ "total_equality_delete_file_size_in_bytes",
Review Comment:
Could you document these fields in "Partitions" section of spark-queries.md?
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -37,6 +37,7 @@
import java.util.Comparator;
import java.util.List;
import java.util.Map;
+import java.util.Objects;
Review Comment:
I'm not sure if we want to fix v3.4. It's deprecated and
https://github.com/apache/iceberg/pull/14122 removes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
