shangxinli commented on code in PR #374:
URL: https://github.com/apache/iceberg-cpp/pull/374#discussion_r2616331727
##########
src/iceberg/file_reader.h:
##########
@@ -76,6 +76,10 @@ class ReaderProperties : public ConfigBase<ReaderProperties>
{
/// \brief The batch size to read.
inline static Entry<int64_t> kBatchSize{"read.batch-size", 4096};
+ /// \brief Use direct Avro decoder (true) or GenericDatum-based decoder
(false).
+ /// Default: true (use direct decoder for better performance).
+ inline static Entry<bool> kAvroUseDirectDecoder{"avro.use-direct-decoder",
true};
Review Comment:
Good suggestion! I've renamed it to follow the naming convention and be more
descriptive.
Changes:
- kAvroUseDirectDecoder → kAvroSkipDatum
- "avro.use-direct-decoder" → "read.avro.skip-datum"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
