amogh-jahagirdar commented on code in PR #14824:
URL: https://github.com/apache/iceberg/pull/14824#discussion_r2616519262
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -137,16 +131,50 @@ public void run() {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
+ failure.compareAndSet(null, new RuntimeException("PlanWorker was
interrupted", e));
Review Comment:
I think you're right that in this particular case we should blow up because
we do not want to indicate an incorrect complete state to a consumer iterator,
because it may not be complete since planning was interrupted. However, I'm a
little doubtful that it makes sense to also blow up when `signcalComplete` is
interrupted because planning is complete at that point, and as a result the
consumer won't see a partial state? Especially since the consumer is also
likely the one also initiating the interrupt (and this structure is also not
intended to be threadsafe from a consumer point of view anyways).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
