singhpk234 commented on PR #14838: URL: https://github.com/apache/iceberg/pull/14838#issuecomment-3650111232
I agree with this in principal and am supportive, but i think its API is more about the way we have it in rest spec rather than impl : https://github.com/apache/iceberg/blob/bc23a774a3cb3b06a63289e445dbf91beb8b5254/open-api/rest-catalog-open-api.yaml#L3408-L3418 > It's also a bit brittle of an API just because someone could pass through file scan tasks and unrelated delete files. Generally I have seen req / response api's being consistent with the spec and the spec says clearly its deletes corresponding to the filescan task, so this case is not possible. I understand our intention was to optimize the pay load to reference the index in FS task. I think we should keep additional watch on other lang impl like python for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
