martyngigg commented on issue #2544: URL: https://github.com/apache/iceberg-python/issues/2544#issuecomment-3656599073
I should have some time to work on a solution this week. I thought I'd sketch my solution here first to avoid going down the wrong path: - Move [`AuthManager`](https://github.com/apache/iceberg-python/blob/e07296ea33a96efd3a100da7bf34c088d3ce8001/pyiceberg/catalog/rest/auth.py#L38) to `pyiceberg.catalog.___init__.py` - Override [`_load_file_io`](https://github.com/apache/iceberg-python/blob/e07296ea33a96efd3a100da7bf34c088d3ce8001/pyiceberg/catalog/__init__.py#L746) in `RestCatalog` and add a property `AUTH_MANAGER` to the set of properties passed to `FileIO.__init__` and ultimately `S3V4RestSigner` - `S3V4RestSigner` pulls out the `AUTH_MANAGER` if one is available and handles requesting the token. Would this be acceptable or is this a bit of a hacky use of the `properties`? Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
