slfan1989 commented on code in PR #1930:
URL: https://github.com/apache/iceberg-rust/pull/1930#discussion_r2621850134
##########
crates/iceberg/src/scan/task.rs:
##########
@@ -104,6 +104,9 @@ pub struct FileScanTask {
#[serde(serialize_with = "serialize_not_implemented")]
#[serde(deserialize_with = "deserialize_not_implemented")]
pub name_mapping: Option<Arc<NameMapping>>,
+
+ /// Whether this scan task should treat column names as case-sensitive
when binding predicates.
+ pub case_sensitive: bool,
Review Comment:
@liurenjie1024 Thank you very much for reviewing the code! Yes, the
`case_sensitive` flag should indeed be set according to the `TableScan`. It
represents a query-level property that needs to flow down through the plan
`context` and `manifest` contexts into each `FileScanTask`, so that
`DeleteFilter` can correctly bind equality delete predicates with the intended
case-sensitivity.
The overall call chain is:
```
TableScan → PlanContext → ManifestFileContext → ManifestEntryContext →
FileScanTask
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
