liurenjie1024 commented on PR #1755: URL: https://github.com/apache/iceberg-rust/pull/1755#issuecomment-3664060643
I have concerns about this pr, where it leaves whole crate in a state inconsisteny with our design. I think to following our design, you don't need to change anything existing. We could name our new trait to be `Storage2`, and adding new implementations gradually. When we reached feature parity in the new storage implemenation, we could use one pr to switch to the new storage implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
