rdblue commented on a change in pull request #1740:
URL: https://github.com/apache/iceberg/pull/1740#discussion_r520963671
##########
File path:
hive3/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergDateObjectInspectorHive3.java
##########
@@ -56,7 +56,15 @@ public DateWritableV2 getPrimitiveWritableObject(Object o) {
@Override
public Object copyObject(Object o) {
- return o == null ? null : new Date((Date) o);
+ if (o == null) {
+ return null;
+ }
+
+ if (o instanceof Date) {
+ return new Date((Date) o);
+ } else {
+ return o;
+ }
Review comment:
Why not support both representations that are possibly passed in by Hive?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
