HuaHuaY commented on code in PR #419: URL: https://github.com/apache/iceberg-cpp/pull/419#discussion_r2627766850
########## src/iceberg/test/mock_catalog.h: ########## @@ -23,6 +23,7 @@ #include <gtest/gtest.h> #include "iceberg/catalog.h" +#include "iceberg/table.h" Review Comment: Fix a bug. Otherwise clang-tidy checks would fail when someone else modified this file (This error seems to only appear under higher versions of gcc, not sure). The reasion is `MOCK_METHOD((Result<std::unique_ptr<Table>>), ...` will instantiate `std::expected<std::unique_ptr<Table>>` but `Table` here is just a forward declaration so `std::unique_ptr` will fail to generate destructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
