lishuxu commented on code in PR #418:
URL: https://github.com/apache/iceberg-cpp/pull/418#discussion_r2629244360
##########
src/iceberg/update/update_properties.cc:
##########
@@ -70,65 +75,56 @@ UpdateProperties& UpdateProperties::Remove(const
std::string& key) {
return *this;
}
-Status UpdateProperties::Apply() {
- if (!catalog_) {
- return InvalidArgument("Catalog is required to apply property updates");
- }
- if (!base_metadata_) {
+Result<PendingUpdate::ApplyResult> UpdateProperties::Apply() {
+ ICEBERG_RETURN_UNEXPECTED(CheckErrors());
+
+ const auto* base_metadata = transaction_->base();
Review Comment:
In a transaction, earlier updates may have updated table_meta in
transaction, I think we should user transaction_->current() as base_metadata
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
