jackye1995 commented on pull request #1633: URL: https://github.com/apache/iceberg/pull/1633#issuecomment-725084420
> > also fixed some issues in S3FileIO found during testing. > > Are these blocking tests, or should we separate them into a different PR? I am not entirely sure which way is the best to go here. Although there are 20 files changed, there are in total 6 main files changed and the rest are all tests so that's why I currently just put them all together. The blocking bug is in `S3OutputStream.close()` line 84, it needs to check `closed` boolean because `TableMetadataParser` tries to close the same input stream twice. ([link](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/TableMetadataParser.java#L117-L118)). All the other changes for S3 are just added tests. I also can pull the fix and added tests for S3 out to another PR if that feels like a better way to go with smaller PRs, please let me know what you think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
